feat(FEC-14189): Ingore referrer kaltura.com in friendly iframe #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
looks ok to me. just note the lint errors.
you can see them in your terminal if you run lint script.
you can fix them 1 by 1 manually or try to use the lint:fix script (it might include more files than you need, so note the files that were changed and that you want to push).
semarche-kaltura
previously approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.
Issue:
When open player iframe on new tab, its referrer is kaltura.com, in such case site based access control will reject it.
Fix:
If we are in friendly iframe and domain is kaltura.com, we ignore it and return the domain that the backend embed inside the iframe bundle
Resolves FEC-14189